From dev-return-10768-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Sat Dec 13 00:39:15 2003 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 23346 invoked from network); 13 Dec 2003 00:39:15 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 13 Dec 2003 00:39:15 -0000 Received: (qmail 84686 invoked by uid 500); 13 Dec 2003 00:39:00 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 84455 invoked by uid 500); 13 Dec 2003 00:38:59 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 84436 invoked from network); 13 Dec 2003 00:38:58 -0000 Date: Fri, 12 Dec 2003 16:38:53 -0800 Subject: Re: [PATCH] Convenience macros for apr array manipulation Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v553) Cc: dev@apr.apache.org To: Sander Striker From: "Roy T. Fielding" In-Reply-To: <1071252440.1568.7093.camel@localhost.localdomain> Message-Id: Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.553) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N >> +#define APR_ARRAY_PUSH(arr, type, item) \ A macro that is intended to mimic the behavior of a function call should always be named in the same way as function calls, not with all-uppercase names. Stuff like the above makes the interface entirely dependent on the implementation, and makes the code harder to read for no reason. ....Roy