apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mladen Turk" <mt...@apache.org>
Subject [PATCH] Fixed timeout for apr_reslist
Date Tue, 09 Dec 2003 15:44:55 GMT
 

> From: Jeff Trawick
> 
> Cliff Woolley wrote:
> > 
> > Is it really correct to return APR_EAGAIN regardless of the return 
> > value of apr_thread_cond_timedwait()?  Or is that a bug caused by a 
> > lack of {}'s?  This is why we tend to say that you should 
> always use 
> > {}'s, even if the conditional block is only one line long.
>

That was the bug.

> if not returning whatever apr_thread_cond_timedwait() 
> returned, why not return APR_TIMEUP instead of APR_EAGAIN?  
> but like Cliff said I wonder why the retval of 
> apr_thread_cond_timewait() isn't appropriate?
> 

The fixed patch uses the returning value from apr_thread_cond_timedwait().
Also changed to apr_reslist_timeout_set.

MT.

Mime
View raw message