apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <...@manyfish.co.uk>
Subject Re: cvs commit: apr/include apr_atomic.h
Date Fri, 05 Dec 2003 13:03:54 GMT
On Fri, Dec 05, 2003 at 06:24:15AM -0500, Jeff Trawick wrote:
> Joe Orton wrote:
> >apr_atomic.c: In function `apr_atomic_add32':
> >apr_atomic.c:205: warning: `old_value' might be used uninitialized in this 
> >function
> >
> >I'd fix it but I'm not sure how... abort()? 
> >assert(apr_thread_mutex_lock(lock) == APR_SUCCESS) instead? return a
> >random value since everything has gone to pot anyway?
> I'd vote for abort() or assert().

Actually assert() like that would be bad since it's a noop if NDEBUG is
defined, so abort() it is.

Mime
View raw message