Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 4 Nov 2003 00:19:40 -0800
From: Greg Stein <gstein@lyra.org>
To: Branko ?ibej <brane@xbc.nu>
Cc: dev@apr.apache.org
Subject: Re: cvs commit: apr/network_io/win32 sockets.c sockopt.c
Message-ID: <20031104001940.A15421@lyra.org>
Mail-Followup-To: Branko ?ibej <brane@xbc.nu>, dev@apr.apache.org
References: <20031102205118.24488.qmail@minotaur.apache.org>
 <3FA6FFAF.6090907@xbc.nu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <3FA6FFAF.6090907@xbc.nu>;
 from brane@xbc.nu on Tue, Nov 04, 2003 at 02:23:59AM +0100

On Tue, Nov 04, 2003 at 02:23:59AM +0100, Branko ?ibej wrote:
> gstein@apache.org wrote:
>...
> >  Also simplified the test/set macros to just take a socket.
>...
> >   #define apr_set_option(mask, option, on) \
> >       do {                                 \
> >           if (on)                          \
> >  -            *mask |= option;             \
> >  +            *(mask) |= (option);         \
> >           else                             \
> >  -            *mask &= ~option;            \
> >  +            *(mask) &= ~(option);        \
> >       } while (0)
> >   
> >   #endif  /* ! NETWORK_IO_H */
>
> Any particular reason for this macro not being the same as the Unix
> version, except making an evil attack on Win32 buildability? :-)

Gah... dealing with too many copies of too many files... Sorry 'bout that.

As you guessed, there was no particular reason. I just missed it and
couldn't get a test win32 compile done. Thanks for the fix!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/