apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: cvs commit: apr/support/unix waitio.c
Date Tue, 18 Nov 2003 12:56:47 GMT
On 17 Nov 2003 01:41:18 -0000, gstein@apache.org wrote:

>gstein      2003/11/16 17:41:18
>
>  Modified:    file_io/os2 filedup.c open.c pipe.c
>               file_io/unix filedup.c open.c pipe.c
>               file_io/win32 filedup.c open.c pipe.c
>               include  apr_support.h
>               include/arch/netware apr_arch_file_io.h
>               include/arch/os2 apr_arch_file_io.h apr_arch_networkio.h
>               include/arch/unix apr_arch_file_io.h apr_arch_networkio.h
>               include/arch/win32 apr_arch_file_io.h apr_arch_networkio.h
>               network_io/beos sendrecv.c
>               network_io/os2 sockets.c
>               network_io/unix sockets.c
>               network_io/win32 sockets.c
>               support/unix waitio.c
>  Log:
>  With the removal of apr_poll(), the apr_wait_for_io_or_timeout() function
>  needed to be rebuilt. Specifically, it needs a pollset, but we don't want
>  to allocate that all the time. Thus, we need to create it once at socket
>  or file creation time, and then reuse that pollset.

You can't poll a file handle on OS/2 (APR_FILES_AS_SOCKETS == 0) so there's
not really much point in having a pollset in the OS/2 apr_file_t, unless
there's some grand scheme you're cooking up that I'm unaware of :)

Should I go ahead & clean them out?

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message