apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject Re: [PATCH] NO_USE_SIGACTION - no use undecorated names
Date Fri, 21 Nov 2003 03:30:33 GMT
At 09:00 PM 11/20/2003, Jeff Trawick wrote:
>William A. Rowe, Jr. wrote:
>
>>We need to axe or decorate the symbol NO_USE_SIGACTION in our
>>ongoing effort to prevent namespace clashes.
>
>sounds good
>
>>We do have a flag APR_HAVE_SIGACTION which is tested and
>>configured for, and the attached patch to the Apache MPMs presumes that this was the
intent of APR_HAVE_SIGACTION.
>
>can you take a look at that patch, Bill?  (hint, save to disk first, then edit :) )

ROFL :-)

>>But it will enable all platforms to use the (likely untested) sigaction
>> code in the various MPMs.
>
>but we're using the sigaction code now...  what platforms besides windows actually have
NO_USE_SIGACTION defined?

Bah - was looking at apr.h not apr.h.in.  You are correct.

>>code in the various MPMs.  If we are choosing on *Apache's* behalf
>>to use (or not use) sigaction, then this flag, or it's newly renamed
>>cousin, needs to be an apache conf variable and disappear altogether
>>from APR.
>>Comments please from those who know the sigaction code?
>
>I think everybody will end up using the same exact code, but the preprocessor check will
be nicer.

Well here's the patch... enjoy

Bill 
Mime
View raw message