apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apr/random/unix apr_random.c
Date Wed, 05 Nov 2003 16:04:53 GMT
Jeff Trawick wrote:

> ben@apache.org wrote:
> 
>> ben         2003/11/05 03:59:54
> 
> 
>>   Code style.
> 
> 
> compilability is another issue ;)
> 
>>   Index: apr_random.h
>>   ===================================================================
>>   RCS file: /home/cvs/apr/include/apr_random.h,v
>>   retrieving revision 1.2
>>   retrieving revision 1.3
>>   diff -u -r1.2 -r1.3
>>   --- apr_random.h    3 Nov 2003 17:50:37 -0000    1.2
>>   +++ apr_random.h    5 Nov 2003 11:59:54 -0000    1.3
>>   @@ -66,14 +66,13 @@
>>                          unsigned char *result);
>>       // FIXME: make this opaque
> 
> 
>      /* FIXME: this is not C99 or C++ or Java */

What's the matter? Did your editor break? :-)

Besides, your revision is wrong...

      /* FIXME: this is not C99 or C++ or Java or gcc */

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff



Mime
View raw message