apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [patch] proc_mutex_flock_child_init() should close the file
Date Thu, 16 Oct 2003 22:31:39 GMT
Gregory (Grisha) Trubetskoy wrote:

> In proc_mutex_flock_child_init(), there is no reason to keep the inherited
> file descriptor open, it results in unnecessary open files. Unless I'm
> missing something it's ok to close it first thing in flock_child_init().

sure, definitely a good thing for it not to be open

but maybe in proc_mutex_flock_create() it should be marked as 
uninheritable?  new child processes wouldn't otherwise know to close the 
file unless they ran the flock_child_init code

View raw message