Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 38174 invoked from network); 29 Sep 2003 01:30:45 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 29 Sep 2003 01:30:45 -0000 Received: (qmail 6496 invoked by uid 500); 29 Sep 2003 01:30:27 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 6455 invoked by uid 500); 29 Sep 2003 01:30:27 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 6435 invoked from network); 29 Sep 2003 01:30:26 -0000 Message-ID: <3F778B3D.3030606@xbc.nu> Date: Mon, 29 Sep 2003 03:30:37 +0200 From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.5) Gecko/20030916 X-Accept-Language: sl, en-gb, en MIME-Version: 1.0 To: Sander Striker CC: dev@apr.apache.org Subject: Re: cvs commit: apr/memory/unix apr_pools.c References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Sander Striker wrote: >>From: Branko Cibej [mailto:brane@xbc.nu] >>Sent: Monday, September 29, 2003 3:22 AM >> >> > > > >>Branko Čibej wrote: >> >> >> >>>Also, I'm being double stupid because it's not APR that doesn't compile, >>>it's APR-iconv. Ho hum. Now how can that happen? >>> >>>/me grumbles and looks >>> >>> >>> >>> >>Huh, not surprising. apr_atomic.h does _not_ define apr_atomic_init on >>Win32, Netware, FreeBSD, Linux, MVS and djgpp; no wonder there are >>dangling references to it in apr_pools.obj. >> >> > >Huh? > >#if defined(WIN32) > >#define apr_atomic_t LONG > >#define apr_atomic_add(mem, val) InterlockedExchangeAdd(mem,val) >#define apr_atomic_dec(mem) InterlockedDecrement(mem) >#define apr_atomic_inc(mem) InterlockedIncrement(mem) >#define apr_atomic_set(mem, val) InterlockedExchange(mem, val) >#define apr_atomic_read(mem) (*mem) >#define apr_atomic_cas(mem,with,cmp) InterlockedCompareExchange(mem,with,cmp) >#define apr_atomic_init(pool) APR_SUCCESS >#define apr_atomic_casptr(mem,with,cmp) InterlockedCompareExchangePointer(mem,with,cmp) > >Looks like a definition to me... Why doesn't this work? > > Uh -- I said HEAD, not the 0.9 branch. > > > >>Since there's a whole bunch of atomics that do _not_ have a >>Win32-specific implementation in apr_atomic.h, my guess is that we need >>to build apr_atomic.c on Windows. >> >> > >Isn't the above the full atomics API? > > >Sander 'getting confused now' > > > -- Brane Čibej http://www.xbc.nu/brane/