apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmpil...@collab.net
Subject Re: [PATCH] apr_filepath_merge (on Windows)
Date Wed, 17 Sep 2003 19:17:17 GMT
"William A. Rowe, Jr." <wrowe@rowe-clan.net> writes:

> Thanks for your patch - and your analysis!  After walking through this bug
> for some time - I believe we converge on the patch, which I've committed.
> Thanks for your patience - I'm only now finding a few cycles to devote
> again to APR.

No sweat.  And thank you for sticking with the task of reviewing and
correcting this, instead of letting it drop.

> >   3.  There was a loop which is calling apr_lstat() to find the true
> >       names of each path segment, but doesn't ignore "." and "..".
> 
> It should never, only leading ../ elements may be preserved!  There should
> never remain an embedded ../ or ./ element after the base parsing is done.
> 
> But what we failed to do was step past the ../../ leading segments 
> and trusting them as known-correct path.  Now, to do that we bypass 
> the 'keptlen' - that part of the path name that is pure from the LHS path 
> expression (we *never* rescan the LHS path, on the appended RHS.)

Ah.  I understand.  Thanks for the explanation.  And the tests (wow!).  

Subversion users the world over will sing your praises.  Well, at
least the Windows users.  And, maybe not all of them.  And ... well,
I'll sing your praises, at least! :-)

Mime
View raw message