apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject RE: [PATCH] Updated atomic API
Date Fri, 19 Sep 2003 20:38:04 GMT
At 01:32 AM 9/19/2003, Mladen Turk wrote:

>I have a patch (send It back in April) that enable to use the atomic
>from C++ on WIN32.
>The problem is the fact that C++ distinguishes unsigned int and LONG
>mixage as an error.

That's our bug, then.  Not redeclaring, but we need to make this consistent.

>Unlike the other platforms for WIN32 the apr_atomic_t is 'typedefed' so
>later in the header it is reverted from LONG to apr_uint32_t, so the
>IntelockedXX functions gets apr_uint32_t as a param, and C++ reports
>that as an error.
>
>The patch simply #defines the apr_atomic_t as LONG.

I don't like this solution - please don't commit.  I will propose a better one 
that accommodates both typesafety concerns and the declarations.

If we agree apr_uint32_t is the desired implementation - then we need to do
some very clever casting to fool even C++.  It can be done, al la dynamic
callback function prototypes.  I'll post the patch this evening.

Bill


Mime
View raw message