apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: [PATCH] apr_reslist - allow Soft/Hard Max to Equal the Minimum
Date Wed, 03 Sep 2003 19:31:01 GMT
This looks good to me. Nice catch. +1

(I'm swamped with other things right now, but if someone hasn't
committed this by today or tomorrow I can do it.)

-aaron


On Wednesday, September 3, 2003, at 11:45  AM, Paul Querna wrote:

> apr_reslist_create() does not allow the Soft Max or the Hard Max to 
> equal the
> Minimum number of resources.
>
> Shouldn't it be possible to create an apr_reslist where the Minimum is 
> also
> the Soft Max?
>
> I have done minimal testing with this patch with my mod_authn_dbi (the 
> only
> apache module that i know of that uses apr_reslist) and it has worked 
> fine.
>
> -chip
>
> Index: apr_reslist.c
> ===================================================================
> RCS file: /home/cvspublic/apr-util/misc/apr_reslist.c,v
> retrieving revision 1.2
> diff -b -u -r1.2 apr_reslist.c
> --- apr_reslist.c       1 Jan 2003 00:02:22 -0000       1.2
> +++ apr_reslist.c       3 Sep 2003 18:36:40 -0000
> @@ -286,7 +286,7 @@
>
>     /* Do some sanity checks so we don't thrash around in the
>      * maintenance routine later. */
> -    if (min  >= smax || min  >= hmax || smax  > hmax || ttl  < 0) {
> +    if (min  > smax || min  > hmax || smax  > hmax || ttl  < 0) {
>         return APR_EINVAL;
>     }
>


Mime
View raw message