Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 2266 invoked by uid 500); 13 Aug 2003 03:28:51 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 2251 invoked from network); 13 Aug 2003 03:28:51 -0000 Subject: Re: [PATCH] bucket debugging. From: Brian Pane To: dev@apr.apache.org In-Reply-To: References: Content-Type: text/plain Organization: Message-Id: <1060745656.16028.4.camel@desktop> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 12 Aug 2003 20:34:16 -0700 Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, 2003-08-12 at 20:20, Cliff Woolley wrote: > Any objections to the following patch? All you do is pass > -DAPR_BUCKET_DEBUG to ./configure and then several things happen: > > 1) the brigades get checked for consistency at various strategic points > 2) and apr_bucket_free() calls are checked for double-free conditions > (eg, you destroyed the same bucket twice, or destroyed one and then > kept on using it, which causes all kinds of nasty and impossible to > debug things to happen). > > If you don't define APR_BUCKET_DEBUG, it's all a no-op and is thrown away > by the preprocessor. +1 Brian