From dev-return-10196-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Aug 13 08:44:51 2003 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 18758 invoked by uid 500); 13 Aug 2003 08:44:50 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 18657 invoked from network); 13 Aug 2003 08:44:46 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Wed, 13 Aug 2003 01:53:43 -0700 From: Greg Stein To: Cliff Woolley Cc: dev@apr.apache.org Subject: Re: [PATCH] bucket debugging. Message-ID: <20030813085343.GC30891@lyra.org> Mail-Followup-To: Cliff Woolley , dev@apr.apache.org References: <20030813053639.GA30695@lyra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-URL: http://www.lyra.org/greg/ X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, Aug 13, 2003 at 02:08:57AM -0400, Cliff Woolley wrote: > On Tue, 12 Aug 2003, Greg Stein wrote: > > > > + while (curr) { > > > + if (node == curr) { > > > + return 0; > > > + } > > > + curr = curr->next; > > > + } > > > + return 1; > > > > Forget the return code. Just stick an abort() in here. > > return 0 to pop the assert, abort, same difference. :) But sure, I'll do > it that way, why not. Sure, six of one, half-dozen of another. But the way I saw it was that the return code was superfluous since the only caller was your macro. Thus, you can just shift all the [abort] logic into the function rather than split between the func and the macro. But in any case, having a consistency check on those buggers is Goodness. Cheers, -g -- Greg Stein, http://www.lyra.org/