apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmpil...@collab.net
Subject Re: [PATCH] apr_filepath_merge (on Windows)
Date Sat, 09 Aug 2003 04:48:20 GMT
"William A. Rowe, Jr." <wrowe@apache.org> writes:

> You need to be aware that APR_FILEPATH_TRUENAME must construct a
> canonical path name.  That is why you are having so many problems.
> It seems that you are asking for ../ to be treated as a 'relative
> root'.  That means that only foo/bar should be normalized.

Sorry, Bill.  I'm not really sure what you mean here.  What I'm asking
is for the Windows and Unix implementations of apr_filepath_merge to
behave in a manner conceptually consistent with one another, something
that is currently not happening.  The Unix code doesn't even note the
APR_FILEPATH_TRUENAME flag, presumably because Unix is case-sensitive,
and thus doesn't need case conversions to occur.  And that's fine, if
case and alias conversion was all that was at stake here, but the
Windows implementation is screwing with the magic '.' and '..'
components, which is not something that the Unix implementation does.

> I'd be happy to look at your issues and patch later this weekend.  Just
> wanted you to know that the note wasn't ignored before then :-)

That's awesome.  Thanks for your time.

If you use Subversion command-line tools on Windows, the bug we're tracking
this with at http://subversion.tigris.org/issues/show_bug.cgi?id=1111,
and it contains a repro recipe.  The recipe fails trying to lock a
directory that should have been accessed as "..\B", but on Windows, that
gets turned into just "B".

View raw message