apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <...@manyfish.co.uk>
Subject Re: [PATCH] locale independent apr_str_eq function
Date Sun, 03 Aug 2003 09:31:01 GMT
On Sun, Aug 03, 2003 at 01:17:15AM +0200, André Malo wrote:
> Well, I've started with a patch (attached). It works fine for me, but I'm not
> sure with the naming at all. Any comments?

I understand the need for a strcasecmp replacement, but are the
strcmp/!strcmp replacements just for consistency? On some platforms
strcmp is an optimised asm inline so unless there's a good reason to
tempt people away from strcmp I'd leave apr_streq/strneq out.

Adding the global arrays to apr_lib.h adds 512 bytes to every object
file which includes that header, not sure that is a good idea, could
result in noticeably bigger executables.

Regards,

joe

Mime
View raw message