Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 14 Jul 2003 10:33:23 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@apr.apache.org
Subject: Re: Improper use of HAVE_DECL_SYS_SIGLIST in
 apr/threadproc/unix/signals.c
Message-ID: <20030714093323.GD8261@redhat.com>
References: <049a01c34883$7da755e0$5400a8c0@starfruit>
 <20030714090206.GC8261@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030714090206.GC8261@redhat.com>
User-Agent: Mutt/1.4.1i

On Mon, Jul 14, 2003 at 10:02:06AM +0100, Joe Orton wrote:
> On Sat, Jul 12, 2003 at 03:38:15PM +0100, Max Bowsher wrote:
> > Unlike most other autoconf defines, this is *defined to 0* when the check
> > symbol is not found. (See info autoconf, search on "Macro: AC_CHECK_DECLS")
> > 
> > The usage in threadproc/unix/signals.c:
> > #if defined(SYS_SIGLIST_DECLARED) || defined(HAVE_DECL_SYS_SIGLIST)
> > is therefore incorrect. Instead, it should be:
> > #if defined(SYS_SIGLIST_DECLARED) || HAVE_DECL_SYS_SIGLIST
> 
> Ooops, thanks Max, I've checked that in.  I now see that sys_siglist is
> *not* getting detected in glibc becase -D_GNU_SOURCE isn't added to
> CPPFLAGS until after a little later on.

Hah.  In fact this macro is completely useless in autoconf 2.57 because
it doesn't #include signal.h, so it will always fail to detect
sys_siglist.