apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PACTH] debug ideas for memory allocation
Date Wed, 02 Jul 2003 23:31:06 GMT
On Thu, Jul 03, 2003 at 01:06:23AM +0200, Sander Striker wrote:
>...
> +++ srclib/apr/memory/unix/apr_pools.c  2 Jul 2003 23:01:10 -0000
> @@ -1212,6 +1212,10 @@
>      if (pool == global_pool || global_pool == NULL)
>          return;
> 
> +    /* A NULL pool?! */
> +    if (!pool)
> +        abort();

I'd suggest moving this above the global_pool check. Otherwise, the
global_pool test could throw you out of the function before you detect a
NULL pool.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message