From dev-return-9991-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon Jun 23 12:37:34 2003 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 49467 invoked by uid 500); 23 Jun 2003 12:37:33 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 49393 invoked from network); 23 Jun 2003 12:37:32 -0000 Mail-Followup-To: dev@apr.apache.org X-Injected-Via-Gmane: http://gmane.org/ To: dev@apr.apache.org From: Joe Schaefer Subject: Re: cvs commit: apr/tables apr_tables.c Date: 23 Jun 2003 08:40:44 -0400 Lines: 55 Message-ID: References: <20030622215026.13619.qmail@icarus.apache.org> <3EF6EC52.1020106@attglobal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@main.gmane.org Mail-Copies-To: never User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 Sender: news X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Jeff Trawick writes: [...] > Partial APR Tests: > Table: ........F > > 9 tests run: 8 passed, 1 failed, 0 not implemented. > > Failed tests in Table: > 1) table_overlap: expected <8> but was <7> With current cvs, that particular subtest (<8> vs <7>) of table_overlap passes, but a later subtest fails for me. This patch seems to fix my problem; I don't know if it will fix yours: Index: tables/apr_tables.c =================================================================== RCS file: /home/cvspublic/apr/tables/apr_tables.c,v retrieving revision 1.48 diff -u -r1.48 apr_tables.c --- tables/apr_tables.c 22 Jun 2003 21:50:25 -0000 1.48 +++ tables/apr_tables.c 23 Jun 2003 12:31:15 -0000 @@ -1176,9 +1176,8 @@ (*sort_next)->key = NULL; } while (++sort_next <= dup_last); } - else { - last = sort_next; - } + + last = sort_next; } /* Shift elements to the left to fill holes left by removing duplicates */ Index: test/testtable.c =================================================================== RCS file: /home/cvspublic/apr/test/testtable.c,v retrieving revision 1.9 diff -u -r1.9 testtable.c --- test/testtable.c 1 Jan 2003 00:01:56 -0000 1.9 +++ test/testtable.c 23 Jun 2003 12:31:15 -0000 @@ -174,7 +174,7 @@ val = apr_table_get(t1, "a"); CuAssertStrEquals(tc, val, "1"); val = apr_table_get(t1, "b"); - CuAssertStrEquals(tc, val, "2"); + CuAssertStrEquals(tc, val, "2."); val = apr_table_get(t1, "c"); CuAssertStrEquals(tc, val, "3"); val = apr_table_get(t1, "d"); -- Joe Schaefer