apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: cvs commit: apr/tables apr_tables.c
Date Mon, 23 Jun 2003 12:40:44 GMT
Jeff Trawick <trawick@attglobal.net> writes:

[...]

> Partial APR Tests:
> Table:                    ........F
> 
> 9 tests run:  8 passed, 1 failed, 0 not implemented.
> 
> Failed tests in Table:
> 1) table_overlap: expected <8> but was <7>

With current cvs, that particular subtest (<8> vs <7>) of
table_overlap passes, but a later subtest fails for me.  This
patch seems to fix my problem; I don't know if it will fix 
yours:

Index: tables/apr_tables.c
===================================================================
RCS file: /home/cvspublic/apr/tables/apr_tables.c,v
retrieving revision 1.48
diff -u -r1.48 apr_tables.c
--- tables/apr_tables.c 22 Jun 2003 21:50:25 -0000      1.48
+++ tables/apr_tables.c 23 Jun 2003 12:31:15 -0000
@@ -1176,9 +1176,8 @@
                 (*sort_next)->key = NULL;
             } while (++sort_next <= dup_last);
         }
-        else {
-            last = sort_next;
-        }
+
+        last = sort_next;
     }

     /* Shift elements to the left to fill holes left by removing duplicates */
Index: test/testtable.c
===================================================================
RCS file: /home/cvspublic/apr/test/testtable.c,v
retrieving revision 1.9
diff -u -r1.9 testtable.c
--- test/testtable.c    1 Jan 2003 00:01:56 -0000       1.9
+++ test/testtable.c    23 Jun 2003 12:31:15 -0000
@@ -174,7 +174,7 @@
     val = apr_table_get(t1, "a");
     CuAssertStrEquals(tc, val, "1");
     val = apr_table_get(t1, "b");
-    CuAssertStrEquals(tc, val, "2");
+    CuAssertStrEquals(tc, val, "2.");
     val = apr_table_get(t1, "c");
     CuAssertStrEquals(tc, val, "3");
     val = apr_table_get(t1, "d");

-- 
Joe Schaefer


Mime
View raw message