apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: [PATCH] table patch using mergesort Re: Frankentables
Date Mon, 23 Jun 2003 21:02:06 GMT
On Mon, 23 Jun 2003, Joe Schaefer wrote:

> OK.  I've looked into the test failures, and it looks to
> me like the cause is a semantic change in apr_table_mergen.
> With the callback API, apr_table_merge with preexisting headers
> will merge *all* of them into a single header, whereas the
> current code only merges *the first* occurrence.
>
> To get the mod_headers tests to pass, here is a patch to
> httpd-test/perl-framework/t/modules/headers.t

Whoa, hang on... -1 to changing the test framework.  If we've had a
semantic change in APR and the test suite caught it, that's a bug in APR
and *not* a bug in the test suite, IMO (unless of course the original
semantics were "wrong" in some way... but even then a semantic change in a
library is not good).

Why the semantic change?

--Cliff

Mime
View raw message