apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <brian.p...@cnet.com>
Subject Re: [PATCH] Re: Frankentables
Date Sun, 18 May 2003 20:09:29 GMT
On Sat, 2003-05-17 at 21:53, Joe Schaefer wrote:
> Joe Schaefer <joe+gmane@sunstarsys.com> writes:
> 
> [...]
> 
> > oprofile tells me this version wins by ~10 - 25% when measuring the
> > time httpd spends in table ops.  To get the full benefit, 
> > ap_get_mime_headers_core in httpd-2.0/server/protocol.c also 
> > needs a patch.
> 
> FWIW here's the oprofile data.  The sample data was generated by
> running 3 passes of (here "/foo" is a zero-byte file)

Thanks for posting the oprofile data.  The results 
look good.  I haven't had time to read through the
code in detail yet, but I'll do that this afternoon.

Based on a first glance at the code, the only thing
that worries me is the comment about apr_table_compress()
taking quadratic time.  I think it's possible to use a
mergesort-based algorithm to do the compress in
n*log(n) time and linear space, though.

Brian



Mime
View raw message