apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] hex format string for apr_uint64_t
Date Tue, 15 Apr 2003 20:42:48 GMT
At 03:22 PM 4/15/2003, Joe Orton wrote:
>On Tue, Apr 15, 2003 at 04:15:32PM -0400, Jeff Trawick wrote:
>> Joe Orton wrote:
>> >On Tue, Apr 15, 2003 at 01:58:23PM -0400, Jeff Trawick wrote:
>> >...
>> >
>> >>#define APR_UINT64_T_FMT_LEN     3
>> >>+#define APR_UINT64_T_HEX_FMT     "llx"
>> >>+#define APR_UINT64_T_HEX_FMT_LEN 3
>> >>#define APR_TIME_T_FMT APR_INT64_T_FMT
>> >
>> >
>> >There's no need to add another _FMT_LEN #define, they are not really
>> >necessary, sizeof() is good for that kind of thing.
>> 
>> I don't like the presence of them either, but if we stop following the 
>> convention that we mysteriously arrived at then I'd like to see the 
>> bunch of them dropped with APR 1.0.
>
>I have a patch pending to remove them, just waiting to make sure my
>apr_snprintf tests pass on all my build machines (which have been
>otherwise engaged) with the old code before committing it. Could use:
>
>#define APR_UINT64_T_HEX_FMT_LEN (sizeof(APR_UINT64_T_HEX_FMT) - 1)
>
>if you're despearate to keep it consistent in the mean time ;)

++1 from the peanut gallery.  Yes - we need to keep them, and yes, I'm
also +1 for /* @deprecated Use sizeof(APR_SOMESTR) - 1 */ in these cases. 




Mime
View raw message