Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 90536 invoked by uid 500); 23 Mar 2003 06:50:10 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 90521 invoked from network); 23 Mar 2003 06:50:10 -0000 Date: Sun, 23 Mar 2003 01:50:26 -0500 From: Craig Rodrigues To: dev@apr.apache.org Subject: Re: [PATCH] fix apr_atomic.h for FreeBSD Message-ID: <20030323065026.GA38763@attbi.com> References: <20030323043954.GA13066@attbi.com> <20030323051743.GA18864@attbi.com> <3E7D5570.8020700@netscape.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E7D5570.8020700@netscape.com> User-Agent: Mutt/1.4i X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, Mar 22, 2003 at 10:34:24PM -0800, Wan-Teh Chang wrote: > It seems that apr_atomic_dec should be defined as > return !atomic_dec_and_test(mem); ^^^^^^^^^^^^^^^^^^^ Did you invent that macro? I can't find it in FreeBSD. > >The Netware implementation of apr_atomic_dec() is similar to what > >I did for FreeBSD: > > > >194 inline int apr_atomic_dec(apr_atomic_t *mem) > >195 { > >196 atomic_dec(mem); > >197 return *mem; > >198 } > > This implementation is not atomic. But it exists in the APR codebase, and is apparently acceptable to Netware people. -- Craig Rodrigues http://home.attbi.com/~rodrigc rodrigc@attbi.com