Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 57302 invoked by uid 500); 20 Mar 2003 15:53:38 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 57217 invoked from network); 20 Mar 2003 15:53:36 -0000 Date: Thu, 20 Mar 2003 15:53:09 +0000 From: Joe Orton To: dev@apr.apache.org Subject: Re: [Patch rev 3] FD_CLOEXEC and APR_INHERIT Message-ID: <20030320155309.GA16636@manyfish.co.uk> Mail-Followup-To: dev@apr.apache.org References: <5.2.0.9.2.20030317170204.0342bd78@pop3.rowe-clan.net> <5.2.0.9.2.20030318230712.01f12ac8@pop3.rowe-clan.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5.2.0.9.2.20030318230712.01f12ac8@pop3.rowe-clan.net> User-Agent: Mutt/1.4i X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, Mar 18, 2003 at 11:18:12PM -0600, William Rowe wrote: > Thanks to the feedback from Joe and Bjoern, I have committed a ton and 1/2 > of bug fixes to apr's open.c and dupfile.c. > > After those changes, this patch is much easier to read. Please take a look > and comment on anything you see that might be amiss. It has two compile failures on Unix, so can I presume you haven't tested this in httpd on a Unix platform? joe