apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bjoern A. Zeeb" <bzeeb-li...@lists.zabbadoz.net>
Subject Re: [Patch] for discussion of FD_CLOEXEC and APR_INHERIT
Date Tue, 18 Mar 2003 00:56:25 GMT
On Mon, 17 Mar 2003, William A. Rowe, Jr. wrote:

Hi,

just skipped through; too late for everything more.

> --- file_io/unix/open.c 6 Mar 2003 09:24:17 -0000       1.110
> +++ file_io/unix/open.c 17 Mar 2003 22:58:30 -0000
...
> @@ -191,7 +213,10 @@
>
>      if (!(flag & APR_FILE_NOCLEANUP)) {
>          apr_pool_cleanup_register((*new)->pool, (void *)(*new),
> -                                  apr_unix_file_cleanup, apr_unix_file_cleanup);
> +                                  apr_unix_file_cleanup,
> +                                  (flag & APR_INHERIT)
> +                                      ? apr_unix_file_cleanup
> +                                      : apr_pool_cleanup_null);

This should be ... ?

  +                                  (flag & APR_INHERIT)
  +                                      ? apr_pool_cleanup_null
  +                                      : apr_unix_file_cleanup);

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/

tech support excuse #427:
    Firmware update in the coffee machine

Mime
View raw message