apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] inheriting pipes
Date Wed, 05 Mar 2003 17:41:44 GMT
At 10:33 AM 3/5/2003, Joe Orton wrote:
>Pipes created by the Unix implementation of apr_file_pipe_create are
>inherited by default, but you can't make them uninherited without
>registering a custom cleanup handler.  Any objections to this patch,
>which lets apr_file_inherit_unset work on a pipe for Unix? (it looks
>like it might already work on Win32).

>      (*in)->flags = (*out)->flags = APR_INHERIT;

Didn't you mean

(*in)->flags |= APR_INHERIT;
(*out)->flags |= APR_INHERIT;

???  You don't want to corrupt their values.  Yes - your patch looks
100% spot-on, +1.  If those pipes are created inherited, we need to
track the current 'setting' correctly.


View raw message