Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 10 Feb 2003 16:02:25 -0800
From: Justin Erenkrantz <justin@erenkrantz.com>
Reply-To: Justin Erenkrantz <justin@erenkrantz.com>
To: Jacob Lewallen <jlewalle@cs.ucr.edu>
cc: dev@apr.apache.org
Subject: Re: [PATCH] apr_queue race condition
Message-ID: <2147483647.1044892945@dhcp31-150.ics.uci.edu>
In-Reply-To: <3E482367.4080305@cs.ucr.edu>
References: <3E46C7ED.7050708@cs.ucr.edu>
 <2147483647.1044884623@dhcp31-150.ics.uci.edu>
 <3E482367.4080305@cs.ucr.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--On Monday, February 10, 2003 2:10 PM -0800 Jacob Lewallen 
<jlewalle@cs.ucr.edu> wrote:

>>
>> Can you do us a big favor and please resubmit the patch without
>> any  whitespace changes?  That is, only diff what you actually
>> changed. We
>
>     No problem. Here she is.

In this case, I'll defer to the people who know this code better than 
I do.

I think even if the queue size is of the correct size, too many 
consumers could rush in and get stuck waiting on the empty case which 
may never come.  So, yeah.  +1 in concept.  This is better than doing 
the broadcast approach which could be expensive.  -- justin