apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject RE: mmap bug?
Date Thu, 27 Feb 2003 16:18:09 GMT
On Thu, 27 Feb 2003, Sander Striker wrote:

>  #else
> -    rv = munmap(mm->mm, mm->size);
> +    if (mm->mm != NULL)
> +      rv = munmap(mm->mm, mm->size);
> +    else
> +      rv = APR_SUCCESS;

Wouldn't it be better to check mmap()'s return value in apr_mmap_create()
and have it return an error rather than checking mm->mm in
apr_mmap_delete()?

--Cliff


Mime
View raw message