apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] locks/win32/thread_cond.c
Date Thu, 27 Feb 2003 19:18:58 GMT
The patch was essentially right, but we need to always fix that
mutex (not only for timeup) and return an os error if we failed for
some reason other than timeup.

The modified patch is committed.  Thanks for forwarding this patch!

Bill



At 02:17 AM 2/24/2003, INOUE Seiichiro wrote:
>Hi,
>
>This is a simple patch as follows.
>This is fixed by OHTANI Hiroki <ohtani@ariel-networks.com>.
>
>Index: thread_cond.c
>===================================================================
>RCS file: /home/cvspublic/apr/locks/win32/thread_cond.c,v
>retrieving revision 1.11
>diff -u -r1.11 thread_cond.c
>--- thread_cond.c       6 Jan 2003 23:44:31 -0000       1.11
>+++ thread_cond.c       24 Feb 2003 08:10:18 -0000
>@@ -144,6 +144,7 @@
>             ReleaseMutex(cond->mutex);
>             if (res == WAIT_TIMEOUT) {
>                 rv = APR_TIMEUP;
>+                apr_thread_mutex_lock(mutex);
>             }
>             return rv;
>         }
>
>Thanks.
>- INOUE Seiichiro <inoue@ariel-networks.com>



Mime
View raw message