apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr-util/test testqueue.c
Date Sat, 22 Feb 2003 18:26:24 GMT
ianh@apache.org wrote:

> ianh        2003/02/22 09:02:48
>
>   Modified:    .        CHANGES
>                include  apr_queue.h
>                misc     apr_queue.c
>                test     testqueue.c
>   Log:
>   API Change:
>      * apr_queue_[try]pop now returns the item pushed, not a reference 
> to it.
>
>   1.10      +2 -2      apr-util/include/apr_queue.h
>
>   Index: apr_queue.h
>   ===================================================================
>   RCS file: /home/cvs/apr-util/include/apr_queue.h,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- apr_queue.h	13 Jan 2003 20:15:50 -0000	1.9
>   +++ apr_queue.h	22 Feb 2003 17:02:48 -0000	1.10
>   @@ -117,7 +117,7 @@
>     * @returns APR_EOF if the queue has been terminated
>     * @returns APR_SUCCESS on a successfull pop
>     */
>   -APU_DECLARE(apr_status_t) apr_queue_pop(apr_queue_t *queue, void 
> **data);
>   +APU_DECLARE(apr_status_t) apr_queue_pop(apr_queue_t *queue, void 
> *data);

uhh, the same change needs to be made in apr_queue.c... the declarations 
there were left as "void **"

fortunately some C compilers actually complain

>   -APU_DECLARE(apr_status_t) apr_queue_trypop(apr_queue_t *queue, void 
> **data);
>   +APU_DECLARE(apr_status_t) apr_queue_trypop(apr_queue_t *queue, void 
> *data);

same issue


Mime
View raw message