apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@apache.org>
Subject Re: [PATCH] Sendfile API compatibility breakage
Date Wed, 12 Feb 2003 20:51:30 GMT
William A. Rowe, Jr. wrote:

> I suggest the following as a friendly compromise to avoid voting... 

this sounds like progress.

> introduce DISABLE, don't drop ENABLE (especially since your patch would *reverse* 
> the meaning of the EnableSendfile directive for httpd 2.0.44 built against 
> a newer apr!!!)  

D'oh!  You're right, good catch.

> Respect both flags unless both are passed to apr_file_open.
> 
> If neither is specified, let the platform author of the apr_sendfile() code decide
> how *safe* it is to enable the feature.  This could include context (such as
> the filesystem if they want to query it) or filesize (<2gb) or whatever choices
> are wise.
> 
> ENABLE and DISABLE would both be explicit overrides to any sanity tests.
> Based on current bugzilla reports, httpd EnableSendfile should gain the
> 'default' state.  So we could turn it on or off, or leave it up to APR.

I think this could be made to work.  I assume the platform author makes the call 
on what to do with sendfile in the default case at apr_file_open time. 
Otherwise there's a lot of code that would have to be churned between httpd and 
apr without much benefit.

I think there should be an MMN bump in the 2.1 stream for this, so independent 
modules can use the new API if they chose to.  In 2.0 stable, IMO we should do 
our best to make it transparent.

Greg


Mime
View raw message