apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] no core on tryacquire in locks/unix/proc_mutex.c
Date Wed, 19 Feb 2003 17:05:22 GMT
--On Wednesday, February 19, 2003 10:37 AM -0600 "William A. Rowe, 
Jr." <wrowe@rowe-clan.net> wrote:

> +1 here - we shouldn't be dispatching to NULL().

A couple of random thoughts:

1) Would it be better to check for NULL before calling the functions?
   (mod_dav tends to do this)

2) Or, how about a proc_mutex_tryacquire_notimpl instead?  Have a
   standard function that just returns APR_ENOTIMPL.
   (buckets tend to do this)

No big deal either way.  -- justin

View raw message