apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <...@manyfish.co.uk>
Subject Re: cvs commit: apr/test testfileinfo.c
Date Sat, 08 Feb 2003 09:20:28 GMT
On Sat, Feb 08, 2003 at 02:36:01AM +0100, Branko ─îibej wrote:
> jorton@apache.org wrote:
> 
> >jorton      2003/02/07 04:33:00
> >
> >  Modified:    test     testfileinfo.c
> >  Log:
> >  test_buffered_write_size: Pass TRUNCATE not EXCL to open so test isn't
> >  guaranteed to fail if run more than once.
> >
> It's not guaranteed to fail, because it uses the APR_DELONCLOSE flag. If
> that's not working, that's a bug in apr_file_open.

Ah, right, I think I must have quit the debugger without letting the
test terminate, sorry.  This is more robust anyway, yes?

> >  Use apr_assert_success for better failure messages.
> >
> Does that mean that all the tests that use CuAsserIintEquals to test for
> APR_SUCCESS should be modified that way?

They can be, sure, but it's a manual process since you have to add in
the context message - all it needs is someone with a big bag of round
tuits.

joe

Mime
View raw message