Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <3E2FBC56.2020604@xbc.nu>
Date: Thu, 23 Jan 2003 10:56:38 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.3a) Gecko/20021212
MIME-Version: 1.0
To: Eric Gillespie <epg@pretzelnet.org>
CC: dev@subversion.tigris.org,  dev@apr.apache.org
Subject: Re: Problem with apr_proc_wait and/or svn_io_run_cmd
References: <23139.1043297048@remus.pretzelnet.org>
In-Reply-To: <23139.1043297048@remus.pretzelnet.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Eric Gillespie wrote:

[snip]

>It may be as simple as changing APR_STATUS_IS_CHILD_NOTDONE, in
>which case apr_proc_wait doesn't need to change at all.  But i am
>not sure that is the solution.  No matter what, svn_io_run_cmd
>will need to change so that it repeats the apr_proc_wait call as
>necessary (unless you want to make apr_proc_wait itself loop over
>waitpid(2), which i think is NOT the way to go).
>
Why not? Interrupted system calls are a very Unixy thing, and can't even
be simulated on Windows, for example. It's very unfriendly to have to
loop on something that's supposed to be a blocking call. I think the
Unix implementation should handle EINTR internally. That's the only way
to make the behaviour the same on all platforms.


-- 
Brane Čibej   <brane@xbc.nu>   http://www.xbc.nu/brane/