Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 73335 invoked by uid 500); 22 Jan 2003 03:20:31 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 73324 invoked from network); 22 Jan 2003 03:20:30 -0000 Message-ID: <3E2E0D88.4080904@xbc.nu> Date: Wed, 22 Jan 2003 04:18:32 +0100 From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212 X-Accept-Language: sl, en-gb, en MIME-Version: 1.0 To: Justin Erenkrantz CC: dev@apr.apache.org Subject: Re: cvs commit: apr-util/crypto apr_md5.c References: <20030121202758.1980.qmail@icarus.apache.org> <2147483647.1043176551@[10.0.1.3]> In-Reply-To: <2147483647.1043176551@[10.0.1.3]> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Rating: 208.185.179.12.available.above.net 1.6.2 0/1000/N Justin Erenkrantz wrote: > --On Tuesday, January 21, 2003 8:27 PM +0000 gstein@apache.org wrote: > >> @@ -145,7 +145,7 @@ >> * @param inputLen The length of the next message block >> */ >> APU_DECLARE(apr_status_t) apr_md5_update(apr_md5_ctx_t *context, >> - const unsigned char > > *input, > >> + const void *input, >> apr_size_t inputLen); >> /** > > > My hunch is that this breaks binary compatibility. Do we need to > bump a version number or do some magic to make our binary compat > people happy? -- justin > It shouldn't. It could only break binary compatibility on systems where the representation and/or size of a void* is different than the representation of a char*, and I bet APR doesn't work on such systems. -- Brane Čibej http://www.xbc.nu/brane/