From dev-return-8952-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Jan 09 22:45:33 2003 Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 89538 invoked by uid 500); 9 Jan 2003 22:45:32 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 89516 invoked from network); 9 Jan 2003 22:45:31 -0000 Message-ID: <3E1DFB8C.5090909@xbc.nu> Date: Thu, 09 Jan 2003 23:45:32 +0100 From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212 X-Accept-Language: sl, en-gb, en MIME-Version: 1.0 To: Greg Stein CC: dev@apr.apache.org Subject: Re: cvs commit: apr-iconv/ces _tbl_simple.c References: <20030109221011.43124.qmail@icarus.apache.org> <20030109143706.F25893@lyra.org> In-Reply-To: <20030109143706.F25893@lyra.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Greg Stein wrote: >On Thu, Jan 09, 2003 at 10:10:11PM -0000, brane@apache.org wrote: > > >>brane 2003/01/09 14:10:11 >> >> Modified: ces _tbl_simple.c >> Log: >> Use a cast to ucs2_t to slence two instances of the following MSVC warning: >> >> warning C4761: integral size mismatch in argument; conversion supplied >> >> In both cases, we know from context that the cast is safe: In the >> first case, the previous statement checks that we're handling a 16-bit >> char; in the second, we're creating one from two bytes. >> >> > >Comments in the code, rather than the CVS log message, might be nice. Two >years from now, when somebody goes to toss the casts, they might not find >the CVS log... > > How right you are. I've been up to my ears in apr-iconv these past couple of weeks, and tend to forget that others might be interested in understanding the code, too... Sorry about that, will fix ASAP. -- Brane Čibej http://www.xbc.nu/brane/