apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: [STATUS] (apr) Wed Jan 22 23:45:34 EST 2003
Date Thu, 23 Jan 2003 18:14:21 GMT
NetWare relies on a lot of the Unix source.  For example, we use
file_io\unix\dir.c which does check for _POSIX_THREAD_SAFE_FUNCTIONS.

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> Craig Rodrigues <rodrigc@attbi.com> Thursday, January 23, 2003
10:07:36 AM >>>
On Thu, Jan 23, 2003 at 09:32:46AM -0700, Brad Nicholes wrote:
>    NetWare does not have _POSIX_THREAD_SAFE_FUNCTIONS defined in
> unistd.h.  

Is there anywhere in the APR code that justifies unconditionally
declaring
_POSIX_THREAD_SAFE_FUNCTIONS in apr.hnw?  None of the netware portions
of APR that I saw checked for it.

> The comment in userinfo.c is just a leftover from when I
> stole the source file from unix.

Ah!  Then I recommend this patch.


Index: groupinfo.c
===================================================================
RCS file: /home/cvspublic/apr/user/netware/groupinfo.c,v
retrieving revision 1.8
diff -u -r1.8 groupinfo.c
--- groupinfo.c	1 Jan 2003 00:02:00 -0000	1.8
+++ groupinfo.c	23 Jan 2003 17:02:06 -0000
@@ -63,7 +63,7 @@
 #include <sys/types.h>
 #endif
 #if APR_HAVE_UNISTD_H
-#include <unistd.h> /* for _POSIX_THREAD_SAFE_FUNCTIONS */
+#include <unistd.h> 
 #endif
 
 APR_DECLARE(apr_status_t) apr_gid_name_get(char **groupname, apr_gid_t
groupid,
Index: userinfo.c
===================================================================
RCS file: /home/cvspublic/apr/user/netware/userinfo.c,v
retrieving revision 1.6
diff -u -r1.6 userinfo.c
--- userinfo.c	1 Jan 2003 00:02:00 -0000	1.6
+++ userinfo.c	23 Jan 2003 17:02:06 -0000
@@ -63,7 +63,7 @@
 #include <sys/types.h>
 #endif
 #if APR_HAVE_UNISTD_H
-#include <unistd.h> /* for _POSIX_THREAD_SAFE_FUNCTIONS */
+#include <unistd.h> 
 #endif
 
 #define PWBUF_SIZE 512



-- 
Craig Rodrigues        
http://home.attbi.com/~rodrigc 
rodrigc@attbi.com

Mime
View raw message