apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Gillespie <...@pretzelnet.org>
Subject [PATCH] Re: Problem with apr_proc_wait and/or svn_io_run_cmd
Date Fri, 24 Jan 2003 01:47:09 GMT
Jeff Trawick <trawick@attglobal.net> writes:

> I can live with that :)
> 
> (yes, I'm psychologically damaged by some of the xyy specials that cutified
> something in APR but chopped off interesting Unix-specific code at the
> knees)

OK, i'm not sure what you're talking about with the "xyy
specials" (i am not that familiar with APR), but the following
patch solves the problem i reported.  The Subversion test suite
now passess completely with ra_svn after applying this patch to
APR.

CCing the Subversion list again because if this patch is accepted
Subversion will NOT need to be changed.

Index: proc.c
===================================================================
RCS file: /home/cvspublic/apr/threadproc/unix/proc.c,v
retrieving revision 1.62
diff -a -u -r1.62 proc.c
--- proc.c	6 Jan 2003 23:44:38 -0000	1.62
+++ proc.c	24 Jan 2003 01:43:42 -0000
@@ -474,7 +474,11 @@
         waitpid_options |= WNOHANG;
     }
 
-    if ((pstatus = waitpid(proc->pid, &exit_int, waitpid_options)) > 0) {
+    do {
+        pstatus = waitpid(proc->pid, &exit_int, waitpid_options);
+    } while (pstatus < 0 && errno == EINTR);
+
+    if (pstatus > 0) {
         proc->pid = pstatus;
 
         if (WIFEXITED(exit_int)) {

Mime
View raw message