apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@apache.org>
Subject Re: [PATCH] create apr_file_mtime_set
Date Sat, 25 Jan 2003 16:11:17 GMT
--On Friday, January 24, 2003 3:53 PM -0800 Matt Kraai 
<kraai@alumni.cmu.edu> wrote:

> Subversion needs to change the files' modification times.  The
> appended patch adds apr_file_mtime_set, which does so.  It also
> adds apr_time_ansi_get, which is used to convert an apr_time_t to
> a time_t.

Most of the manpages I read say that we should use utimes() not 
utime().  It seems it'd be good to get away from using the utimbuf 
structure if at all possible.  I'm not sure about the general 
availability of utimes() though (autoconf test?).

I would think it would be best to have apr_time_ansi_get as a macro 
rather than a function.  (And that macro should just use the 
apr_time_as_sec macro with an appropriate cast.)

I would also suggest reviewing the style guidelines.  You have tabs 
and no braces around if statements.  -- justin

View raw message