apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thom May <t...@planetarytramp.net>
Subject Re: warnings from sys/syslimits.h on FreeBSD 5.0
Date Tue, 21 Jan 2003 16:01:05 GMT
* Craig Rodrigues (rodrigc@attbi.com) wrote :
> On Tue, Jan 21, 2003 at 09:51:47AM -0500, Garrett Rooney wrote:
> > looking in apr.h where we include sys/syslimits.h, we're also including 
> > limits.h, which on this system gets us the contents of sys/syslimits.h 
> > anyway, so my first instinct is to change it to only include 
> > sys/syslimits.h if we don't have limits.h, but i suppose that is likely 
> > to break on other systems or something...
> 
> Idea 1:
>   - remove include of <sys/syslimits.h> unless someone can prove that
>     not including it will break something

I'm sure something somewhere will break ;-)

> 
> Idea 2:
>   - Change:
> /* header files for PATH_MAX, _POSIX_PATH_MAX */
> #if APR_HAVE_SYS_SYSLIMITS_H
> #include <sys/syslimits.h>
> #endif
> #if APR_HAVE_LIMITS_H
> #include <limits.h>
> #endif
> 
> 
>    to:
> 
> /* header files for PATH_MAX, _POSIX_PATH_MAX */
> #if APR_HAVE_LIMITS_H
> #include <limits.h>
> #endif
> #if APR_HAVE_SYS_SYSLIMITS_H
> #include <sys/syslimits.h>
> #endif
surely you mean: 

#include <limits.h>
#elsif APR_HAVE_SYS_SYSLIMITS_H
#include ...

otherwise we still have the same problem?
-Thom

Mime
View raw message