Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <5.1.0.14.2.20021219011132.0218b3f8@pop3.rowe-clan.net>
Date: Thu, 19 Dec 2002 01:12:42 -0600
To: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu>
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: [PATCH] apr_dir_read doesn't return requested information
Cc: dev@apr.apache.org, Philip Martin <philip@codematters.co.uk>,
        dev@subversion.tigris.org
In-Reply-To: <3E011E99.7050804@xbc.nu>
References: <87bs3jct2y.fsf@codematters.co.uk>
 <5.1.0.14.2.20021217225946.02a1ae90@pop3.rowe-clan.net>
 <3DFCC43F.F6B93489@sebastian-bergmann.de>
 <87fzsz6o1o.fsf@codematters.co.uk>
 <3DFD61A3.D6C1DFF@sebastian-bergmann.de>
 <87znr60wpx.fsf@codematters.co.uk>
 <3DFE128D.14A41D65@sebastian-bergmann.de>
 <87pts122qe.fsf@codematters.co.uk>
 <3DFE4431.9F5DA96E@sebastian-bergmann.de>
 <8765tt1qzo.fsf_-_@codematters.co.uk>
 <87k7i9zcbc.fsf_-_@codematters.co.uk>
 <5.1.0.14.2.20021217215518.03670928@pop3.rowe-clan.net>
 <5.1.0.14.2.20021217225946.02a1ae90@pop3.rowe-clan.net>
 <5.1.0.14.2.20021218123230.042cec58@pop3.rowe-clan.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

As much as I agree 0 might be a valid inode... I strongly suspect
that 0 would be reserved for the boot sector or other filesystem
tables.  I'm not too worried that 0 is a valid file of anything other than
'/'

Bill

At 07:19 PM 12/18/2002, =3D?UTF-8?B?QnJhbmtvIMSMaWJlag=3D=3D?=3D wrote:
>William A. Rowe, Jr. wrote:
>
>>At 11:48 AM 12/18/2002, William A. Rowe, Jr. wrote:
>> =20
>>
>>>At 08:14 AM 12/18/2002, Philip Martin wrote:
>>>   =20
>>>
>>>>This is for dir.c version 1.71 with the patch reverted.  The
>>>>Subversion code is svn_io_get_dirents in subversion/libsvn_subr/io.c,
>>>>it passes APR_FINFO_TYPE | APR_FINFO_NAME to apr_dir_read.  The first
>>>>two calls to apr_dir_read return "." and ".." and the Subversion code
>>>>skips them, the following gdb information is for the third call
>>>>     =20
>>>>
>>
>>,,, never mind my earlier questions.  Committed a patch to ignore the
>>results of d_type when it's DT_UNKNOWN (or a code we don't grok)
>>and ignore the results of d_fileno/d_ino when the value is 0 or -1.
>> =20
>>
>Yes, I'd figured on something like that being the correct fix. But I'm
>not sure what to use as an invalid inode number; -1 almost certainly,
>but I have a horrible suspicion that 0 might be a valid inode.
>
>--=20
>Brane =C4=8Cibej   <brane@xbc.nu>   http://www.xbc.nu/brane/