apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@apache.org>
Subject Re: [PATCH] Update to Brian's patch to allocate brigades out of the bucket allocator
Date Sat, 21 Dec 2002 05:41:32 GMT
On Fri, 20 Dec 2002, William A. Rowe, Jr. wrote:

> At 08:33 PM 12/20/2002, Brian Pane wrote:
> >On Fri, 2002-12-20 at 13:50, rbb@apache.org wrote:
> >
> >> > Basically, if you received a brigade from a higher filter, you can only
> >> > assume that it will survive a single trip down the filter stack.
> >
> >Right.  And you also can't assume that the context that passed
> >the brigade down the filter stack still exists by the time the
> >brigade reaches the last filter.  It's a safe assumption in
> >httpd-2.0, where the brigade is passed as a synchronous function
> >call, but it's not valid for apps in general (potentially including
> >future Apache versions) where the brigade may be queued up for
> >asynchronous processing by an I/O completion thread.
>
> No, it simply will have to be valid.  Not that the context will be
> bound to a specific thread (it won't), and not that the content will
> be living in a given context.

Please read my response to Brian, it isn't a valid assumption in
httpd-2.0.

> Bottom line, we can't break it till we push out APR 1.0.  This leaves
> a very useful question.  Do buckets/brigades remain in apr-util with
> the release of 1.0?  We've just proven that the concept is both very
> apr and very httpd centric.  There is no reason we should burden
> apr with the 'learning curve' of redesigning this code.
>
> I suggest we consider the benefits of pulling buckets/brigades from
> apr-util with the 1.0 release of the apr library, and move that code
> back into httpd if we plan to keep abusing it this way.
>
> apr and apr-util should be repositories for proven concepts, if not
> always proven code.  If we are still redesigning, something is wrong.

I consider this an incorrect statement.  New concepts should be welcome
anywhere.  My question is more basic.  Is the bucket/brigade concept
useful outside of the web server/web client libraries that are being
discussed?  If so, then they should stay where they are.  If not, then
move 'em back into the httpd project.

Of course, I don't believe that apr-util is a useful library currently, so
that could be why I am against keeping buckets and brigades in it.  That
library won't be useful until it has more holding it together than "These
are concepts that were useful in Apache, so we exported them".

Ryan


Mime
View raw message