apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject Re: cvs commit: apr/include apr_errno.h
Date Sun, 29 Dec 2002 23:23:33 GMT
This patch comes up just a bit short.

Because a user *may* choose to use the explicit value APR_ESYMNOTFOUND,
the test APR_STATUS_IS_ESYMNOTFOUND must always include it, as well
as any platform-specific values.

What about other cases as well, such as 'not a module' (invalid format)?

Bill


At 04:50 PM 12/29/2002, rbb@apache.org wrote:
>rbb         2002/12/29 14:50:13
>
>  Modified:    include  apr_errno.h
>  Log:
>  Get the new DSO error values working on Windows.  Windows now passes all
>  DSO tests.
>  
>  Revision  Changes    Path
>  1.107     +8 -0      apr/include/apr_errno.h
>  
>  Index: apr_errno.h
>  ===================================================================
>  RCS file: /home/cvs/apr/include/apr_errno.h,v
>  retrieving revision 1.106
>  retrieving revision 1.107
>  diff -u -r1.106 -r1.107
>  --- apr_errno.h       29 Dec 2002 22:31:45 -0000      1.106
>  +++ apr_errno.h       29 Dec 2002 22:50:13 -0000      1.107
>  @@ -369,7 +369,11 @@
>    * APR was unable to open the dso object.  
>    * For more information call apr_dso_error().
>    */
>  +#if defined(WIN32)
>  +#define APR_STATUS_IS_EDSOOPEN(s)       (APR_TO_OS_ERROR(s) == ERROR_MOD_NOT_FOUND)
>  +#else
>   #define APR_STATUS_IS_EDSOOPEN(s)       ((s) == APR_EDSOOPEN)
>  +#endif
>   /** The given path was absolute. */
>   #define APR_STATUS_IS_EABSOLUTE(s)      ((s) == APR_EABSOLUTE)
>   /** The given path was relative. */
>  @@ -383,7 +387,11 @@
>   /** The given path contained wildcards. */
>   #define APR_STATUS_IS_EPATHWILD(s)      ((s) == APR_EPATHWILD)
>   /** Could not find the requested symbol. */
>  +#if defined(WIN32)
>  +#define APR_STATUS_IS_ESYMNOTFOUND(s)   (APR_TO_OS_ERROR(s) == ERROR_PROC_NOT_FOUND)
>  +#else
>   #define APR_STATUS_IS_ESYMNOTFOUND(s)   ((s) == APR_ESYMNOTFOUND)
>  +#endif
>   
>   /* APR STATUS VALUES */
>   /** @see APR_STATUS_IS_INCHILD */
>  
>  
>  


Mime
View raw message