apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject RE: apr_xlate not thread safe
Date Fri, 08 Nov 2002 22:23:30 GMT
> > >>
> > >> Better that we document which returned apr_foo_t's are threadsafe,
> > >> which ones are not,
> > >
> > > Yep.
> > 
> > Nah.  Subversion was doing something incredibly stupid.  We were 
> > walking up the pools until it found the global_pool and then created 
> > the apr_xlate_t in there and just reused that.  The global_pool has 
> > no guarantee on being thread-safe within the context of httpd.
> > 
> > It has nothing to do with apr_xlate_t.  It has everything to do with 
> > using the global_pool and the false assumption that it was threadsafe.
> > 
> > I don't think it's a big deal that we (in APR) have to worry about, 
> > but that's just me.  -- justin
> 
> I agree with Justin.  It really sounds like this was the APR equivalent of
> using a global variable.  None of the APR types can be used the way that
> Justing has described.
> 
> Ryan

Okay. I did not know the exact nature of the bug in subversion. 

Bill 



Mime
View raw message