apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <phi...@codematters.co.uk>
Subject Re: [PATCH] Re: apr_proc_mutex is broken
Date Tue, 19 Nov 2002 23:04:41 GMT
<rbb@rkbloom.net> writes:

> Follow my logic please.

[snip explanation]

I see, thanks.

> The real fix for this problem is to fix the test code as I have stated
> above so that it is a valid example of how to write APR code, and to fix
> the library so that we register cleanups with a public function, and so
> that apr_proc_mutex_child_init does the right thing in all cases.  I will
> do the work later tonight (assuming my wife doesn't go into labor before
> then) unless somebody beats me to it.

I think the test should also be changed to better exercise the mutex
behaviour, i.e. replace (*x)++ with "read, wait, increment, write".
Had the test been written like this originally it would not have
passed erroneously.  It may also help when/if someone ports APR to a
new platform.

-- 
Philip Martin

Mime
View raw message