apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apr/test testpools.c
Date Wed, 23 Oct 2002 15:00:28 GMT
On 23 Oct 2002, Jeff Trawick wrote:

> rbb@apache.org writes:
> 
> > I actually considered doing this, but I don't believe that it is a good
> > idea.  The problem is the amount of information you get if things
> > fail.  With this change you get:
> > 
> > 50 tests run:  49 passed, 1 failed, 0 not implemented.
> > Failed tests:
> > 1) calloc_bytes: assert failed
> > 
> > Without it, you get:
> > 
> > 50 tests run:  49 passed, 1 failed, 0 not implemented.
> > Failed tests:
> > 1) calloc_bytes: expected pointer <(nil)> but was <0x61>
> > 
> > I would mucch rather have the added information.
> 
> The previous code was not valid C.
> 
> "testpools.c", line 101.37: 1506-280 (S) Function argument assignment
> between types "void*" and "char" is not allowed.
> 
> Maybe you want to add an appropriate flavor of CuAssert that checks
> characters?

Ok, I'll get this fixed today.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
550 Jean St
Oakland CA 94610
-------------------------------------------------------------------------------


Mime
View raw message