apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apr/test Makefile.in test_apr.h testall.c testmmap.c
Date Sun, 13 Oct 2002 15:49:38 GMT
On Sun, 13 Oct 2002, Greg Stein wrote:

> On Sun, Oct 13, 2002 at 05:28:15AM -0000, rbb@apache.org wrote:
> >...
> >   +++ testall.c	13 Oct 2002 05:28:15 -0000	1.5
> >   @@ -57,7 +57,7 @@
> >    
> >    #include "test_apr.h"
> >    
> >   -#define NUM_TESTS 4
> >   +#define NUM_TESTS 5
> >    
> >    apr_pool_t *p;
> >    
> >   @@ -67,7 +67,8 @@
> >        teststr,
> >        testtime,
> >        testvsn,
> >   -    testipsub
> >   +    testipsub,
> >   +    testmmap
> >    };
> 
> You keep bumping NUM_TESTS and adding entries to the array. You can avoid
> the dual-maintenance and potential for falling out of sync by adding a NULL
> element ("sentinel") to the array to signify the end.

DAmn, do I feel dumb now.  I make that change tonight.  Thanks.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
550 Jean St
Oakland CA 94610
-------------------------------------------------------------------------------


Mime
View raw message