apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@apache.org>
Subject RE: Renames Pending.
Date Thu, 31 Oct 2002 08:55:11 GMT
> From: Bill Stoddard [mailto:bill@wstoddard.com]
> Sent: 30 October 2002 14:37

> The APR API sounds like is was created by Yoda; every command ends in a verb.
> "Fooled you I did, hummm?" :-)

*LOL*
 
>> At 06:19 AM 10/30/2002, Thom May wrote:
>>> Ok, here goes (this is much more practical than the patch):

[...]
>>> apr_socket_shutdown              from apr_shutdown
>>> apr_socket_bind                  from apr_bind
>>> apr_socket_listen                from apr_listen
>>> apr_socket_accept                from apr_accept
>>> apr_socket_connect               from apr_connect
>>> apr_socket_send                  from apr_send
>>> apr_socket_sendv                 from apr_sendv
>>> apr_socket_sendto                from apr_sendto
>>> apr_socket_recvfrom              from apr_recvfrom
>>> apr_socket_sendfile              from apr_sendfile
>>> apr_socket_recv                  from apr_recv
>>
>> I was about to make the old complaint that these api's are overkill,
>> standard names, etc.  And then I considered apr_file_t and it's functions.
>> So +1 here, even over those old objections, for each function which
>> operates on (has a first argument of) an apr_socket_t.  But there are
>> exceptions...

+1.
 
> -0. I would prefer to leave them alone (yadda yadda yadda).
 
>>> apr_socket_filter_accept         from apr_socket_accept_filter
>>
>> This is in the apr_socket_accept family, why rearrange order here?

Leave it as apr_socket_accept_filter.

>>> apr_hostname_get                from apr_gethostname
>>> apr_port_addr_parse             from apr_parse_addr_port
>>> apr_sockaddr_fromname_set       from apr_getservbyname
>>> apr_sockaddr_hostname_get       from apr_getnameinfo
>>
>> Bleh.  Ick.  There isn't consistency here.  These will be difficult
>> for coders to recall.  They are a little rough, don't you think?
> 
> -1 leave them alone.

Agreed.  -1.
 
>>> apr_socket_file_create           from apr_socket_from_file
>>
>> Hmmm.  What is it creating?  How?  This name is pretty ambigious.
> 
> -1. Leave it as it is.

Same.
 
[...]
>>> apr_time_exp_gmt_get            from apr_implode_gmt
>>
>> Grumpf.  Another hard to use name... I have to look at the big time
>> picture again to see if that's the right solution.
> 
> -1

Ahum, +1 for this change.  The rest of the time functions follow the
same pattern.

[...]


Sander

Mime
View raw message