apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject RE: [PATCH] Support APR_APPEND (O_APPEND) with apr_file_write on Windows
Date Fri, 25 Oct 2002 19:22:31 GMT
At 01:48 PM 10/25/2002, Bill Stoddard wrote:
>> Nope.  APR_XTHREAD files must be readable, writeable and totally
>> compatible with APR_APPEND.
>
>That's not possible assuming APR_APPEND has the same semantic meaning as Unix O_APPEND.

Of course it is.  O_APPEND always appends.  We simply do the same
locking, no seek, grab the current lof and keep going as we were.

>> It's a couple of extra LOC, please add
>> them or post the final patch for me to massage.  These files have APR
>> maintained file pointers for compatibility with the API.
>
>Yes, if the file is opened with APR_BUFFERED, then APR maintains it's own
>file pointers. My patch is not touching the APR_BUFFERED path.

The pointer filePtr is also used throughout for APR_XTHREAD...
just look at apr/file_io/win32/seek.c.  Simply use apr_file_seek after
locking in the Overlapped case, with APR_END, 0 as your args.

Bill


Mime
View raw message